Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wasm-bindgen to 0.2.88 #2240

Merged

Conversation

alexkirsz
Copy link
Contributor

No description provided.

@alexkirsz alexkirsz force-pushed the alexkirsz/update-wasm-bindgen branch from ba6442c to e3eb57f Compare November 7, 2023 18:12
@@ -9,35 +9,13 @@ exports_files([
crates_vendor(
name = "crates_vendor",
annotations = {
"curl-sys": [crate.annotation(
gen_build_script = False,
)],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was prompted to remove these two annotations when running: bazel run //wasm_bindgen/3rdparty:crates_vendor -- --repin:

Error: Unused annotations were provided. Please remove them: [CrateId { name: "curl-sys", version: "*" }, CrateId { name: "openssl-sys", version: "*" }]

[[test]]
name = "reference"
[package.metadata.binstall]
bin-dir = "wasm-bindgen-{ version }-{ target }/{ bin }{ binary-ext }"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to recompute this diff as the dist Cargo.toml changed.

Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@UebelAndre UebelAndre merged commit cebd731 into bazelbuild:main Nov 7, 2023
@alexkirsz alexkirsz deleted the alexkirsz/update-wasm-bindgen branch November 8, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants